[exporter/elasticsearch] Fix CloudID parsing to correctly handle Elastic Cloud IDs when sent with multiple dollar sign separators #44325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tic Cloud IDs when sent with multiple dollar sign separators Signed-off-by: Paulo Dias <[email protected]>
carsonip
approved these changes
Nov 18, 2025
axw
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CloudID decoder was incorrectly using
strings.Cut(), which only splits at the first delimiter, resulting in malformed URLs when the decoded CloudID contained multiple$separators. Changed to usestrings.Split()to match the reference implementation from the go-elasticsearch library.Link to tracking issue
Fixes #44306
Testing
Added tests to validate this behaviour and the expected output.