-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Move metricstarttimeprocessor to beta #43912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braydonk
approved these changes
Oct 30, 2025
|
Lets wait for #43914 before merging. |
ridwanmsharif
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
cc @eriksywu |
songy23
approved these changes
Oct 31, 2025
songy23
pushed a commit
that referenced
this pull request
Nov 5, 2025
#### Description Promote the receiver.prometheusreceiver.RemoveStartTimeAdjustment to beta, which disables metric start time adjustment by default. #### Link to tracking issue Fixes #43656 #### Testing Tests were updated to test with the featue gate enabled and disabled. @ridwanmsharif This should wait until after #43912 to merge. --------- Co-authored-by: Arthur Silva Sens <[email protected]>
jelly-afk
pushed a commit
to jelly-afk/opentelemetry-collector-contrib
that referenced
this pull request
Nov 6, 2025
#### Description Move the metricstarttime processor to beta. We have been using it in production, and have fixed issues that have come up. At this point, we don't see needing any breaking chagnes, so it is time to move it to beta, and replace the adjustment in the prometheus receiver. #### Link to tracking issue Part of open-telemetry#43656 @ridwanmsharif
jelly-afk
pushed a commit
to jelly-afk/opentelemetry-collector-contrib
that referenced
this pull request
Nov 6, 2025
…lemetry#43916) #### Description Promote the receiver.prometheusreceiver.RemoveStartTimeAdjustment to beta, which disables metric start time adjustment by default. #### Link to tracking issue Fixes open-telemetry#43656 #### Testing Tests were updated to test with the featue gate enabled and disabled. @ridwanmsharif This should wait until after open-telemetry#43912 to merge. --------- Co-authored-by: Arthur Silva Sens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the metricstarttime processor to beta. We have been using it in production, and have fixed issues that have come up. At this point, we don't see needing any breaking chagnes, so it is time to move it to beta, and replace the adjustment in the prometheus receiver.
Link to tracking issue
Part of #43656
@ridwanmsharif