[chore] move e2e tests out of datadogexporter to reduce dependencies #42805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
IbraheemA,
ankitpatel96,
dineshg13,
jade-guiton-dd,
liustanley and
mackjmr
atoulme
commented
Sep 21, 2025
atoulme
force-pushed
the
move_out_e2e_tests
branch
5 times, most recently
from
e47cc47 to
d3d66ae
Compare
paulojmdias
approved these changes
Sep 22, 2025
mx-psi
reviewed
Sep 22, 2025
atoulme
force-pushed
the
move_out_e2e_tests
branch
from
d3d66ae to
f435a19
Compare
atoulme
force-pushed
the
move_out_e2e_tests
branch
2 times, most recently
from
e4cfac9 to
eaf3f49
Compare
jade-guiton-dd
approved these changes
Oct 6, 2025
Contributor
jade-guiton-dd
left a comment
jade-guiton-dd
left a comment
There was a problem hiding this comment.
Looks like some of the import statements will need to be updated for the latest core release, and you may need to re-run make crosslink to fix the replace statements; otherwise looks good.
atoulme
force-pushed
the
move_out_e2e_tests
branch
from
eaf3f49 to
2c8142b
Compare
atoulme
force-pushed
the
move_out_e2e_tests
branch
from
2c8142b to
a6e3b4d
Compare
atoulme
added
the
ready to merge
etserend
pushed a commit
to etserend/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2025
…pen-telemetry#42805) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Some dependencies of datadogexporter are other components, which themselves are bringing over dependencies to anyone using this exporter. This PR moves the e2e tests to a separate module to avoid this complexity. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#42591
mashhurs
pushed a commit
to mashhurs/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2025
…pen-telemetry#42805) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Some dependencies of datadogexporter are other components, which themselves are bringing over dependencies to anyone using this exporter. This PR moves the e2e tests to a separate module to avoid this complexity. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#42591
tommyers-elastic
pushed a commit
to tommyers-elastic/opentelemetry-collector-contrib
that referenced
this pull request
Oct 10, 2025
…pen-telemetry#42805) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Some dependencies of datadogexporter are other components, which themselves are bringing over dependencies to anyone using this exporter. This PR moves the e2e tests to a separate module to avoid this complexity. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#42591
atoulme
pushed a commit
that referenced
this pull request
Oct 24, 2025
#### Description #42805 moved Datadog's E2E tests into `internal/e2e`, and the example configurations used as part of the tests into `internal/e2e/examples`. The intent was to move the tests into `internal/datadog/e2e` instead, but it looks like this change was accidentally reverted during a force push. Moreover, it seems that moving the example configs created some broken links (eg. [here, "collector.yaml"](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/datadogexporter#datadog-exporter), [here, "example configuration"](https://docs.datadoghq.com/opentelemetry/setup/collector_exporter/deploy/?tab=gateway#kubernetes)). This PR: - moves `internal/e2e` to `internal/datadog/e2e` - moves the example configs back to their original location to restore these links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some dependencies of datadogexporter are other components, which themselves are bringing over dependencies to anyone using this exporter. This PR moves the e2e tests to a separate module to avoid this complexity.
Link to tracking issue
Fixes #42591