Skip to content

Conversation

@jackgopack4
Copy link
Contributor

@jackgopack4 jackgopack4 commented Sep 3, 2025

Description

remove references to Datadog/opentelemetry-mapping-go library. This library has been completely replaced by copies inside datadog-agent and will be archived soon.

Link to tracking issue

Fixes internal issue

Testing

migrate existing tests

Documentation

chloggen

@jackgopack4 jackgopack4 changed the title [datadog] update datadog-agent libraries [datadog] update datadog-agent libraries OTAGENT-516 Sep 3, 2025
@jackgopack4 jackgopack4 force-pushed the jackgopack4/bump-otel-mapping-go branch from 005daa0 to 6b3b2ff Compare September 4, 2025 11:49
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you first do a PR to replace the go 1.24 directive by go 1.24.0 in all modules?

It should be as easy as running:

make for-all CMD="go mod edit -go=1.24.0"
make gotidy

Thanks!

@jackgopack4
Copy link
Contributor Author

@mx-psi see #42490

mx-psi pushed a commit that referenced this pull request Sep 4, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
As seen in #42475 (and potentially others), certain dependencies may
bump gomod to specific version. setting gomod to go 1.24.0 shouldn't
impact anything more than setting go 1.23.0 on previous versions did.
<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Prerequisite for #42475

<!--Describe what testing was performed and which tests were added.-->
#### Testing
existing tests
<!--Describe the documentation added.-->
#### Documentation
none needed
<!--Please delete paragraphs that you did not use before submitting.-->
@jackgopack4 jackgopack4 force-pushed the jackgopack4/bump-otel-mapping-go branch from 6b3b2ff to 8f77f51 Compare September 4, 2025 13:36
@jackgopack4
Copy link
Contributor Author

rebased on main following #42490

@jackgopack4
Copy link
Contributor Author

looks like internal/otelarrow test failing unrelated #42486

dims *metrics.Dimensions,
typ metrics.DataType,
timestamp uint64,
_ int64,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do this in a follow up PR but this can be actually passed if you modify NewMetric

@mx-psi mx-psi merged commit 67d8ff8 into open-telemetry:main Sep 4, 2025
303 of 305 checks passed
@mx-psi mx-psi deleted the jackgopack4/bump-otel-mapping-go branch September 4, 2025 14:23
@github-actions github-actions bot added this to the next release milestone Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants