-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[datadog] update datadog-agent libraries OTAGENT-516 #42475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[datadog] update datadog-agent libraries OTAGENT-516 #42475
Conversation
005daa0 to
6b3b2ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you first do a PR to replace the go 1.24 directive by go 1.24.0 in all modules?
It should be as easy as running:
make for-all CMD="go mod edit -go=1.24.0"
make gotidy
Thanks!
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description As seen in #42475 (and potentially others), certain dependencies may bump gomod to specific version. setting gomod to go 1.24.0 shouldn't impact anything more than setting go 1.23.0 on previous versions did. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Prerequisite for #42475 <!--Describe what testing was performed and which tests were added.--> #### Testing existing tests <!--Describe the documentation added.--> #### Documentation none needed <!--Please delete paragraphs that you did not use before submitting.-->
6b3b2ff to
8f77f51
Compare
|
rebased on main following #42490 |
|
looks like internal/otelarrow test failing unrelated #42486 |
| dims *metrics.Dimensions, | ||
| typ metrics.DataType, | ||
| timestamp uint64, | ||
| _ int64, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do this in a follow up PR but this can be actually passed if you modify NewMetric
Description
remove references to Datadog/opentelemetry-mapping-go library. This library has been completely replaced by copies inside datadog-agent and will be archived soon.
Link to tracking issue
Fixes internal issue
Testing
migrate existing tests
Documentation
chloggen