Skip to content

Conversation

@mterhar
Copy link
Member

@mterhar mterhar commented Aug 26, 2025

Description

Saw that zstd compressed data coming into the receiver throws panics on the req.ReadAll() function call.

This pull request addresses it in two ways.

  1. It adds a panic catch around the ReadAll() to avoid crashing the process.
  2. It allows users to disable compression which fixes the issue in an existing deployment

Testing

  • Added test that draws the panic behavior

Documentation

Added configuration information to the README.md for the receiver.

@mterhar mterhar force-pushed the libhoney-fix-reading-request-body branch from 680d2bd to 4d5c45f Compare September 3, 2025 15:24
@mterhar mterhar force-pushed the libhoney-fix-reading-request-body branch from 339049c to 95aa289 Compare September 3, 2025 17:59
@mterhar mterhar marked this pull request as ready for review September 3, 2025 18:06
@mterhar mterhar requested review from a team and TylerHelmuth as code owners September 3, 2025 18:07
@mterhar mterhar force-pushed the libhoney-fix-reading-request-body branch from 95aa289 to 51b5ba8 Compare September 3, 2025 18:53
@codeboten codeboten merged commit 93fe1c9 into open-telemetry:main Sep 3, 2025
184 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants