-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[oracledb/receiver] Removing the toLowercase on sql_text in topN & adding child_address into samples payload #42164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d query_sample collection
Oracledbreceiver events
Oracle additional attributes
…nto samples payload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reasoning behind removing the ToLower call?
Also, if it isn't too much work, it's best to have a PR for only one specific change at a time, rather than combining. This will allow each change to get merged as soon as it's ready, and the review process simpler. Not necessarily required, but if this PR doesn't get approved and merged quickly, you can try splitting it up for quicker progress.
Agree! |
Description
Removing the toLowercase conversion on sql text in top_query payload. Also, adding child_address into the query_samples payload.
Link to tracking issue
Fixes #37478
Testing unit tests updated
Documentation updated