Skip to content

Conversation

@sv-splunk
Copy link
Contributor

Description

Removing the toLowercase conversion on sql text in top_query payload. Also, adding child_address into the query_samples payload.

Link to tracking issue

Fixes #37478

Testing unit tests updated

Documentation updated

Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning behind removing the ToLower call?

Also, if it isn't too much work, it's best to have a PR for only one specific change at a time, rather than combining. This will allow each change to get merged as soon as it's ready, and the review process simpler. Not necessarily required, but if this PR doesn't get approved and merged quickly, you can try splitting it up for quicker progress.

@sv-splunk
Copy link
Contributor Author

sv-splunk commented Aug 21, 2025

What's the reasoning behind removing the ToLower call?

ToLower is removed so the SQL query texts are further ingested in it's original form, which the users would prefer too. Also it helps with any further formatting in the downstream systems.

Also, if it isn't too much work, it's best to have a PR for only one specific change at a time, rather than combining. This will allow each change to get merged as soon as it's ready, and the review process simpler. Not necessarily required, but if this PR doesn't get approved and merged quickly, you can try splitting it up for quicker progress.

Agree!

@crobert-1

@dmitryax dmitryax merged commit 01de308 into open-telemetry:main Aug 22, 2025
186 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add query-level metrics along with query text and query execution plan

6 participants