-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[connector/metricsaslogsconnector] first version of metricsaslogs connector #42052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
unit test output $ go test -cover |
|
@kyo-ke : Kindly visit the Contributing Guidelines found at CONTRIBUTING.md To make things faster, find the quick fixes below, but I insist you to kindly go through the link above for a smooth process Steps to fix all the failing checks:
After fixing all the above, make a push to the same branch of your fork, and allow all the above checks to PASS Cheers... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly make the necessary changes, follow the steps in my comment above and also the contributing guidelienes
|
@aarvee11 Thank you for he review. |
|
@kyo-ke Please resolve the comments above that are open for the CI to kick in and finish the tests |
|
sure |
|
Update to latest main, then run |
…rib into metricsaslogsconnector
…try-collector-contrib into metricsaslogsconnector
|
@atoulme Thank you for review! |
|
@atoulme |
CI says:
Please add it to the list. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
hello @atoulme |
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
|
Could you please update the |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
I hope we get this in now. I am around to merge after CI concludes. |
|
Thank you for your contribution @kyo-ke! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
Description
First version of metricsaslogs connector.
this connector connect metric pipeline to log pipeline
what it do is
create LogRecord per DataPoint
attributes are mapped to
Metric Resource -> Log Resource
Metric Scope -> Log Scope
datapoint -> logrecord
Link to tracking issue
Fixes #40938
Testing
unit test with over 90% coverage
Documentation