-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Downgrade go.opentelemetry.io/otel/exporters/prometheus to v0.58.0 #41869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not be useful outside of this repository, since replace statements in a go.mod A are ignored by the go.mod of other modules that require A. Is this still useful?
6265c95 to
a92cee4
Compare
|
Good point @mx-psi I re-purposed this PR to manually downgrade go.opentelemetry.io/otel/exporters/prometheus to v0.58.0 in all mods. Ideally we should have something like open-telemetry/opentelemetry-collector#13519 in contrib to prevent it being accidentally bumped to v0.59 again. cc @iblancasa |
Description
Similar to open-telemetry/opentelemetry-collector-releases#1067 but for contrib
This avoids accidentally pulling in go.opentelemetry.io/otel/exporters/prometheus v0.59.x when building your distros. v0.59.x has a known bug in metric names. See open-telemetry/opentelemetry-collector#13466.
Link to tracking issue
open-telemetry/opentelemetry-collector#13544