[chore] convert configgrpc.Keepalive params to configoptional #41342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
receiver/otelarrow
receiver/opencensus
internal/otelarrow
labels
mx-psi
merged commit ccefa29
into
open-telemetry:otelbot/update-otel-1752672247
50 of 51 checks passed
mx-psi
deleted the
jackgopack4/OTEL-2684-convert-keepalive-configgrpc-configoptional
branch
|
erm, it looks like opencensus receiver lifecycle tests were failing. I was looking into this and considered re-adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: otelbot [email protected]
Description
Convert tests/modules using
configgrpc.Keepaliveparameters to configoptionalLink to tracking issue
Required due to open-telemetry/opentelemetry-collector#13364
Testing
existing unit/e2e/integration tests
Documentation
none, no change to users or api in this repo