[chore][CI/CD] Always run windows tests for receiver/sqlserver PRs #38863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
commented
Mar 21, 2025
| done | ||
|
|
||
| if [[ $LABELS =~ "receiver/sqlserver" ]]; then | ||
| LABELS+=",Run Windows" |
Member
Author
There was a problem hiding this comment.
- You can add the same label multiple times in the
ghCLI, it will only get added in GitHub once (in other words, adding multiple times is the same operation as once, it's an idempotent operation.) - Tested on another repo, adding labels with spaces works without issue.
- Tested on another repo, there must not be a space after the delimiting comma.
songy23
approved these changes
Mar 21, 2025
atoulme
approved these changes
Mar 21, 2025
Contributor
atoulme
left a comment
atoulme
left a comment
There was a problem hiding this comment.
bit of a hack to put this in the codeowners script but I'd rather have it.
Member
Author
Good idea, I can open a no-op PR to test once it's merged 👍 |
Member
Author
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…pen-telemetry#38863) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The SQL Server receiver heavily depends on Windows functionality, and every change should be tested on Windows. Failing tests are often hit as a result of forgetting to add the `Run Windows` label. I'm sure there's a better way to do this logic that would allow for adding more components to the list of components that require `Run Windows`, so I'm happy to hear feedback. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Flakiness introduced because we forgot to add the `Run Windows` label in just the last couple of days: open-telemetry#38813 open-telemetry#38842 <!--Describe what testing was performed and which tests were added.--> #### Testing Tested the regex matching, it worked with `receiver/sqlserver` as exact match, in the middle of a string, beginning of string, end of string, and not in string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SQL Server receiver heavily depends on Windows functionality, and every change should be tested on Windows. Failing tests are often hit as a result of forgetting to add the
Run Windowslabel.I'm sure there's a better way to do this logic that would allow for adding more components to the list of components that require
Run Windows, so I'm happy to hear feedback.Link to tracking issue
Flakiness introduced because we forgot to add the
Run Windowslabel in just the last couple of days:#38813
#38842
Testing
Tested the regex matching, it worked with
receiver/sqlserveras exact match, in the middle of a string, beginning of string, end of string, and not in string.