[receiver/prometheusremotewritereceiver] Add MetricIdentity struct with xxhash-based hash method #38795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sujalshah-bit
requested review from
a team,
ArthurSens and
dashpole
as code owners
sujalshah-bit
force-pushed
the
hash_func_metric_identity
branch
2 times, most recently
from
1686df6 to
5e6ac5b
Compare
Contributor
|
Please address review and mark the PR as ready for review afterwards. And thank you for this contribution! |
sujalshah-bit
force-pushed
the
hash_func_metric_identity
branch
from
5e6ac5b to
0e5e318
Compare
Contributor
Author
|
hey @perebaj made the changes you suggested kindly review :) |
ArthurSens
reviewed
Mar 21, 2025
Member
ArthurSens
left a comment
ArthurSens
left a comment
There was a problem hiding this comment.
Thank you, pretty close to done!
…h-based Hash method. Creates MetricIdentity struct for uniquely identifying metrics and adds a deterministic Hash method using xxhash with proper field separation. partly fixes open-telemetry#37277.
sujalshah-bit
force-pushed
the
hash_func_metric_identity
branch
from
0e5e318 to
23429c3
Compare
Contributor
Author
|
@ArthurSens made the change thanks for reviewing :) |
ArthurSens
approved these changes
Mar 21, 2025
Member
ArthurSens
left a comment
ArthurSens
left a comment
There was a problem hiding this comment.
LGTM, could you switch from draft mode?
ArthurSens
added
the
ready to merge
perebaj
approved these changes
Mar 21, 2025
Contributor
Author
|
done :) |
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…th xxhash-based hash method (open-telemetry#38795) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Creates MetricIdentity struct for uniquely identifying metrics and adds a deterministic Hash method using xxhash with proper field separation. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue partly fixes open-telemetry#37277. <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates MetricIdentity struct for uniquely identifying metrics and adds a deterministic Hash method using xxhash with proper field separation.
Link to tracking issue
partly fixes #37277.
Testing
Documentation