Add ability to process metrics in schema processor #38628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MovieStoreGuy
left a comment
MovieStoreGuy
left a comment
There was a problem hiding this comment.
Only a minor nit, but I am happy with the progress so far.
| "go.opentelemetry.io/collector/pdata/pmetric" | ||
| ) | ||
|
|
||
| func TestMetrics_RenameAttributes(t *testing.T) { |
Contributor
There was a problem hiding this comment.
From memory, there is a test function that allows you to define this information in a yaml form and compare against an expected yaml file for pdata values.
I suspect this might be more useful here since manually validating each is going to be time consuming.
Member
Author
There was a problem hiding this comment.
I have updated tests to use yaml. Can you please take a look.
…ema-processor-add-functioality-metrics
…ema-processor-add-functioality-metrics
…ema-processor-add-functioality-metrics
atoulme
reviewed
Mar 18, 2025
Contributor
|
Please add more tests to cover the error paths. |
…ema-processor-add-functioality-metrics
…ema-processor-add-functioality-metrics
This was referenced Mar 23, 2025
MovieStoreGuy
approved these changes
Mar 24, 2025
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Add ability to process metrics in schema processor <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ability to process metrics in schema processor
Link to tracking issue
Fixes
Testing
Documentation