Skip to content

Conversation

@atoulme
Copy link
Contributor

@atoulme atoulme commented Mar 5, 2025

Unexport structs, funcs and constants that should not be exposed outside the module.

@atoulme atoulme requested a review from a team as a code owner March 5, 2025 19:26
@atoulme atoulme requested a review from dashpole March 5, 2025 19:26
@github-actions github-actions bot requested review from StefanKurek and schmikei March 5, 2025 19:27
@atoulme
Copy link
Contributor Author

atoulme commented Mar 6, 2025

Maybe I need an API changelog here. I am not sure. Still waiting for codeowners to review first.

@atoulme
Copy link
Contributor Author

atoulme commented Mar 7, 2025

@schmikei @StefanKurek please review

Copy link
Contributor

@StefanKurek StefanKurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok to me

@atoulme atoulme merged commit 818dc95 into open-telemetry:main Mar 10, 2025
171 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants