[receiver/awss3receiver]: Add ingest progress notifications via OpAMP #33980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use OpAMP custom messages to report progress of start/end time based ingest from an S3 bucket.
Contributor
|
Please fix the conflict. Please have @evan-bradley and @tigrannajaryan review as this involves opAmp. |
adcharre
requested review from
BinaryFissionGames,
evan-bradley and
tigrannajaryan
Contributor
Author
|
@atoulme / @evan-bradley / @tigrannajaryan / @BinaryFissionGames - Can I get another review please! |
atoulme
reviewed
Sep 25, 2024
atoulme
approved these changes
Sep 25, 2024
Contributor
atoulme
left a comment
atoulme
left a comment
There was a problem hiding this comment.
Approved. One nit to secure the code a bit more, but not really needed, since you're checking for notifier itself in Shutdown.
Contributor
Author
|
@fatsheep9146 - can this now be merged please? |
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
ghost
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add support for monitoring the progress of ingesting data from an S3 bucket via OpAMP custom messages.
This change would allow an appropriate UI to display the state of ingested.
This is a re-working of #33047 to use OTLP structures instead of a custom JSON object following discussions here: https://cloud-native.slack.com/archives/C02J58HR58R/p1715714974462069
Link to tracking Issue: #30750
Testing: Additional unit tests added. Full stack testing using a built collector and the example OpAMP server provided in the PR.
Documentation: README.md updated to include details of the configuration changes and details of the OpAMP Custom Capability and message format.