Standarize params #3268
Closed
Standarize params #3268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmatyjasek-sumo
requested review from
anuraaga,
arminru,
djaglowski,
dmitryax,
jmacd,
jpkrohling,
jrcamp,
kbrockhoff and
owais
as code owners
Signed-off-by: Patryk Matyjasek <[email protected]> # Conflicts: # cmd/otelcontribcol/main.go # exporter/awsemfexporter/emf_exporter.go # exporter/awsemfexporter/factory_test.go # exporter/awsxrayexporter/awsxray.go # exporter/awsxrayexporter/factory_test.go # exporter/datadogexporter/factory_test.go # exporter/datadogexporter/metadata/metadata.go # exporter/datadogexporter/metadata/metadata_test.go # exporter/datadogexporter/metrics_exporter.go # exporter/datadogexporter/traces_exporter.go # exporter/dynatraceexporter/factory_test.go # exporter/f5cloudexporter/factory.go # exporter/googlecloudexporter/googlecloud.go # exporter/googlecloudexporter/googlecloud_test.go # exporter/honeycombexporter/factory_test.go # exporter/loadbalancingexporter/loadbalancer_test.go # exporter/loadbalancingexporter/log_exporter.go # exporter/loadbalancingexporter/trace_exporter.go # exporter/loadbalancingexporter/trace_exporter_test.go # exporter/logzioexporter/factory_test.go # exporter/newrelicexporter/factory.go # exporter/newrelicexporter/newrelic_test.go # exporter/sapmexporter/exporter_test.go # exporter/uptraceexporter/factory_test.go # extension/storage/filestorage/factory.go # internal/stanza/factory.go # processor/metricstransformprocessor/factory.go # processor/resourcedetectionprocessor/factory.go # receiver/prometheusexecreceiver/factory_test.go # receiver/receivercreator/receiver.go # receiver/receivercreator/runner.go # receiver/receivercreator/runner_test.go
# Conflicts: # go.sum
pmatyjasek-sumo
force-pushed
the
pm_standarize_params_refactor
branch
from
82df77c to
af38d5b
Compare
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Contributor
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
2 tasks
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
* Create snyk-container-analysis.yml * Create snyk-container-analysis.yml * Renamed occurrences of Application to Collector - Changed references in function/method docs from 'application' to 'collector server' - Changed instance variable names from (app *Application) to (col *Collector) * Rename more instances of Application to Collector - renamed files in service/application* to service/collector* - replaced occurrences of app to col * Renamed references of service.Application to collector (or collector server) * Added change log entry stub * Added number of PR * Fixed merge conflicts * Update CHANGELOG.md * Renamed ColSettings to CollectorSettings * Fixed naming error * Delete snyk-container-analysis.yml * Moved change log entry unreleased section From v0.28.0-beta to unreleased (breaking change) * Deleted extra new line in change log * Renamed occurrences of Application to Collector - Changed references in function/method docs from 'application' to 'collector server' - Changed instance variable names from (app *Application) to (col *Collector) * Rename more instances of Application to Collector - renamed files in service/application* to service/collector* - replaced occurrences of app to col * Renamed references of service.Application to collector (or collector server) * Added number of PR * Fixed merge conflicts * Renamed ColSettings to CollectorSettings * Fixed naming error * Moved change log entry unreleased section From v0.28.0-beta to unreleased (breaking change) * Removed misplaced newline Co-authored-by: Karen Xu <[email protected]> Co-authored-by: Iris Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on open-telemetry/opentelemetry-collector#2991
Description:
A proposal solution of standarize constructors parameters
Description:
Fixes open-telemetry/opentelemetry-collector#2650
Changes:
Replace: ReceiverCreateParams, ProcessorCreateParams, ExtensionCreateParams and ExporterCreateParams with ComponentSettings struct
Replace all dependencies in Extensions, Exporters, Processors and Receivers
Replace Parameters and settings structs with new struct Settings
Replace dependencies in service and main
Update tests
Link to tracking Issue:
open-telemetry/opentelemetry-collector#2650
Testing:
Documentation: