[extension/opamp]: Add mechanism to detect whether the collector has been orphaned #32564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
evan-bradley,
portertech and
tigrannajaryan
BinaryFissionGames
force-pushed
the
feat/opamp-extension-monitor-ppid
branch
from
9c7ac76 to
42b03db
Compare
Contributor
evan-bradley
left a comment
evan-bradley
left a comment
There was a problem hiding this comment.
Sorry, I forgot to publish my review. Mostly looks good to me, just a few comments. I'll take another look through it shortly.
evan-bradley
approved these changes
Apr 29, 2024
srikanthccv
reviewed
May 1, 2024
BinaryFissionGames
force-pushed
the
feat/opamp-extension-monitor-ppid
branch
2 times, most recently
from
287fc82 to
f09e1f4
Compare
BinaryFissionGames
force-pushed
the
feat/opamp-extension-monitor-ppid
branch
from
20978e6 to
51ec112
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue: This is part of #32189 - It does not resolve this issue because the supervisor still needs changes to pass the its PID in.
Testing:
Added some unit tests.
I've manually tested it on my macbook with this PR: observIQ#4715
(running supervisor, kill -9 the supervisor, and take a look at the agent logs to see it shut down).
I've tried testing this out on Windows, but the supervisor doesn't get past bootstrapping (the Commander's Stop function does not work on windows), so I wasn't able to fully test it.
Documentation:
Added new parameter to README