[receiver/awss3receiver] Introduce the AWS S3 Receiver #31710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
reviewed
Mar 12, 2024
Member
crobert-1
left a comment
crobert-1
left a comment
There was a problem hiding this comment.
Since this change includes tests, can you add goleak tests as well? It's a recently added requirement for writing new components 👍
atoulme
approved these changes
Mar 14, 2024
crobert-1
reviewed
Mar 14, 2024
atoulme
added
the
ready to merge
Contributor
Author
|
@crobert-1 / @mx-psi - Anything left for me to do here before this PR can be merged? |
Member
Nothing that I'm aware of. Since the (I didn't get a chance to look through thoroughly enough to approve, but I don't have any notable concerns here.) |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Initial skeleton implementation of the AWS S3 receiver described in issue #30750.
Full implementation will follow in future PRs.
Link to tracking Issue: #30750
Testing: -
Documentation: Initial README added.