[exporter/datadogexporter] Add source tag to metrics client #31528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
connector/datadog
exporter/datadog
mx-psi
reviewed
Mar 1, 2024
mx-psi
reviewed
Mar 1, 2024
songy23
reviewed
Mar 1, 2024
Member
songy23
left a comment
songy23
left a comment
There was a problem hiding this comment.
Can you test the source tag in integration_test as well?
Co-authored-by: Pablo Baeyens <[email protected]>
Contributor
Author
Chatted with @songy23 and decided this isn't necessary because these metrics are Prometheus metrics and not APM stats. |
songy23
approved these changes
Mar 1, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…emetry#31528) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Add `source:{datadogexporter|datadogconnector}` tag to trace agent telemetry metrics. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add
source:{datadogexporter|datadogconnector}tag to trace agent telemetry metrics.Link to tracking Issue:
Testing:
Documentation: