Skip to content

[chore] remove nil_nextConsumer tests as we don't allow passing a nil next consumer #31174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2024
Merged

[chore] remove nil_nextConsumer tests as we don't allow passing a nil next consumer #31174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions processor/probabilisticsamplerprocessor/logsprocessor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,6 @@ func TestNewLogsProcessor(t *testing.T) {
cfg *Config
wantErr bool
}{
{
name: "nil_nextConsumer",
cfg: &Config{
SamplingPercentage: 15.5,
},
wantErr: true,
},
{
name: "happy_path",
nextConsumer: consumertest.NewNop(),
Expand Down
7 changes: 0 additions & 7 deletions processor/probabilisticsamplerprocessor/tracesprocessor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,6 @@ func TestNewTracesProcessor(t *testing.T) {
cfg *Config
wantErr bool
}{
{
name: "nil_nextConsumer",
cfg: &Config{
SamplingPercentage: 15.5,
},
wantErr: true,
},
{
name: "happy_path",
nextConsumer: consumertest.NewNop(),
Expand Down
8 changes: 0 additions & 8 deletions receiver/carbonreceiver/receiver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/component/componenttest"
"go.opentelemetry.io/collector/config/confignet"
"go.opentelemetry.io/collector/consumer"
Expand Down Expand Up @@ -57,13 +56,6 @@ func Test_carbonreceiver_New(t *testing.T) {
nextConsumer: consumertest.NewNop(),
},
},
{
name: "nil_nextConsumer",
args: args{
config: *defaultConfig,
},
wantErr: component.ErrNilNextConsumer,
},
{
name: "empty_endpoint",
args: args{
Expand Down
7 changes: 0 additions & 7 deletions receiver/signalfxreceiver/receiver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,6 @@ func Test_signalfxeceiver_New(t *testing.T) {
args args
wantStartErr error
}{
{
name: "nil_nextConsumer",
args: args{
config: *defaultConfig,
},
wantStartErr: component.ErrNilNextConsumer,
},
{
name: "default_endpoint",
args: args{
Expand Down
14 changes: 0 additions & 14 deletions receiver/splunkhecreceiver/receiver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,6 @@ func Test_splunkhecreceiver_NewLogsReceiver(t *testing.T) {
args args
wantErr error
}{
{
name: "nil_nextConsumer",
args: args{
config: *defaultConfig,
},
wantErr: errNilNextLogsConsumer,
},
{
name: "empty_endpoint",
args: args{
Expand Down Expand Up @@ -117,13 +110,6 @@ func Test_splunkhecreceiver_NewMetricsReceiver(t *testing.T) {
args args
wantErr error
}{
{
name: "nil_nextConsumer",
args: args{
config: *defaultConfig,
},
wantErr: errNilNextMetricsConsumer,
},
{
name: "empty_endpoint",
args: args{
Expand Down
28 changes: 0 additions & 28 deletions receiver/statsdreceiver/receiver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/component/componenttest"
"go.opentelemetry.io/collector/config/confignet"
"go.opentelemetry.io/collector/consumer"
Expand All @@ -24,33 +23,6 @@ import (
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/statsdreceiver/internal/transport/client"
)

func Test_statsdreceiver_New(t *testing.T) {
defaultConfig := createDefaultConfig().(*Config)
type args struct {
config Config
nextConsumer consumer.Metrics
}
tests := []struct {
name string
args args
wantErr error
}{
{
name: "nil_nextConsumer",
args: args{
config: *defaultConfig,
},
wantErr: component.ErrNilNextConsumer,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
_, err := newReceiver(receivertest.NewNopCreateSettings(), tt.args.config, tt.args.nextConsumer)
assert.Equal(t, tt.wantErr, err)
})
}
}

func Test_statsdreceiver_Start(t *testing.T) {
type args struct {
config Config
Expand Down