[receiver/signalfx] Accept otlp metrics #31008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
Feb 1, 2024
Member
dmitryax
left a comment
dmitryax
left a comment
There was a problem hiding this comment.
Functionality looks good to me. just minor code comments
dmitryax
reviewed
Feb 9, 2024
dmitryax
approved these changes
Feb 9, 2024
Member
dmitryax
left a comment
dmitryax
left a comment
There was a problem hiding this comment.
Couple nits. Otherwise, LGTM
vasireddy99
added a commit
to vasireddy99/opentelemetry-collector-contrib
that referenced
this pull request
May 7, 2024
This reverts commit c0ce352.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Accept OTLP payloads on /v2/datapoint api of the SignalFx receiver
Link to tracking Issue: #26298
Testing: Updated tests
Documentation: