Fix the build: revert "feat: add datadog trace translation helpers and tests (#1208)" #1273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
approved these changes
Oct 15, 2020
Contributor
|
Just for context, here is the alternative roll-forward PR, CI is running now but looks like it should pass, #1274. Up to you which route you prefer to take, figured a roll forward is slightly easier than a revert as the fix is trivial, and we're comfortable with not having windows support for tracing for the datadogexporter for the first release as we work to remove the need for CGO((metrics would still be supported on windows since they do not rely on the underlying package which needs cgo). |
…d tests (open-telemetry#1208)" This reverts commit 8d6f04c. The "master" build was failing: https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector-contrib/4960/workflows/85f1e1cf-60fd-44d1-88f5-2c86884038c0/jobs/36766 It appears it was because the new commit needs CGO. We don't allow CGO in the Collector. I am reverting this temporarily until a proper solution is found.
tigrannajaryan
force-pushed
the
feature/tigran/revert-fail
branch
from
10d5ac5 to
0a62ec8
Compare
Member
Author
|
Will close this in favor of #1274 once that it merged. |
Member
Author
|
Closing in favor of #1274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8d6f04c.
The "master" build was failing: https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector-contrib/4960/workflows/85f1e1cf-60fd-44d1-88f5-2c86884038c0/jobs/36766
It appears it was because the new commit needs CGO. We don't allow CGO in the
Collector. I am reverting this temporarily until a proper solution is found.