Skip to content

Conversation

@james-bebbington
Copy link
Member

@james-bebbington james-bebbington commented Oct 9, 2020

Add windows-test build step similar to core as per #1175 (comment)

  • Fix simple tests that fail on Windows
  • Disable non-simple tests that fail on Windows (will create issues for people to look into these)

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #1228 into master will increase coverage by 13.94%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1228       +/-   ##
===========================================
+ Coverage   76.01%   89.95%   +13.94%     
===========================================
  Files          24      283      +259     
  Lines        1163    13772    +12609     
===========================================
+ Hits          884    12389    +11505     
- Misses        226     1015      +789     
- Partials       53      368      +315     
Flag Coverage Δ
#integration 76.09% <ø> (+0.08%) ⬆️
#unit 89.11% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/signalfxexporter/ttlmap/ttl_map.go 100.00% <0.00%> (ø)
...resourcedetectionprocessor/internal/gcp/gce/gce.go 100.00% <0.00%> (ø)
exporter/signalfxexporter/factory.go 86.95% <0.00%> (ø)
receiver/kubeletstatsreceiver/config.go 100.00% <0.00%> (ø)
receiver/collectdreceiver/collectd.go 92.53% <0.00%> (ø)
exporter/jaegerthrifthttpexporter/factory.go 100.00% <0.00%> (ø)
...ceiver/awsxrayreceiver/internal/translator/name.go 100.00% <0.00%> (ø)
...ermetricsreceiver/awsecscontainermetrics/client.go 94.44% <0.00%> (ø)
exporter/datadogexporter/config.go 90.90% <0.00%> (ø)
processor/k8sprocessor/kube/client.go 100.00% <0.00%> (ø)
... and 263 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 450f782...8863eeb. Read the comment docs.

@james-bebbington james-bebbington marked this pull request as ready for review October 9, 2020 08:07
@james-bebbington james-bebbington requested a review from a team October 9, 2020 08:07
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want this in Contrib?

@james-bebbington
Copy link
Member Author

james-bebbington commented Oct 9, 2020

Hmmm quite a lot of tests fail on Windows by the looks of it.

I've fixed a couple of simple errors, and disabled the rest for now. I can create an issue for each component that has errors for these to be fixed (or confirmed that these components should be left disabled if this functionality is not intended to work on Windows). WDYT?

@james-bebbington james-bebbington force-pushed the windows-test branch 2 times, most recently from 90bc651 to 2c0b5fc Compare October 10, 2020 03:11
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused a lot of issues due to calls to strings.Split not cleaning up the carriage return characters. It's only test code so safe to make this change here.

@bogdandrutu bogdandrutu merged commit 8fc5098 into open-telemetry:master Oct 14, 2020
tigrannajaryan pushed a commit that referenced this pull request Oct 15, 2020
This PR removes windows support for trace export for the datadog exporter for windows as it relies on packages which use cgo/gcc, which are causing the `windows-test` build step to fail #1228. 

It should fix the failing build on master, cc @tigrannajaryan @mx-psi @james-bebbington
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
codeboten pushed a commit that referenced this pull request Nov 23, 2022
codeboten pushed a commit that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants