-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add windows-test build step #1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows-test build step #1228
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1228 +/- ##
===========================================
+ Coverage 76.01% 89.95% +13.94%
===========================================
Files 24 283 +259
Lines 1163 13772 +12609
===========================================
+ Hits 884 12389 +11505
- Misses 226 1015 +789
- Partials 53 368 +315
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
c523968 to
2ce2837
Compare
.circleci/config.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we want this in Contrib?
|
Hmmm quite a lot of tests fail on Windows by the looks of it. I've fixed a couple of simple errors, and disabled the rest for now. I can create an issue for each component that has errors for these to be fixed (or confirmed that these components should be left disabled if this functionality is not intended to work on Windows). WDYT? |
90bc651 to
2c0b5fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This caused a lot of issues due to calls to strings.Split not cleaning up the carriage return characters. It's only test code so safe to make this change here.
2c0b5fc to
5d52477
Compare
5d52477 to
318d51f
Compare
318d51f to
8863eeb
Compare
This PR removes windows support for trace export for the datadog exporter for windows as it relies on packages which use cgo/gcc, which are causing the `windows-test` build step to fail #1228. It should fix the failing build on master, cc @tigrannajaryan @mx-psi @james-bebbington
Signed-off-by: Bogdan Drutu <[email protected]>
Add
windows-testbuild step similar to core as per #1175 (comment)