-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Description
Component(s)
pkg/translator/jaeger
What happened?
Description
When implementing e2e integration tests for jaeger-v2 we encountered a conversion issue jaegertracing/jaeger#5322 (comment)
Expected Result
binary attributes in OTEL should be represented as binary tags in Jaeger
Actual Result
transformers in both directions encode binary as base64. Behavior introduced in #14574
opentelemetry-collector-contrib/pkg/translator/jaeger/traces_to_jaegerproto.go
Lines 141 to 143 in 5f1488f
| case pcommon.ValueTypeBytes: | |
| tag.VType = model.ValueType_STRING | |
| tag.VStr = base64.StdEncoding.EncodeToString(attr.Bytes().AsRaw()) |
opentelemetry-collector-contrib/pkg/translator/jaeger/jaegerproto_to_traces.go
Lines 242 to 243 in 5f1488f
| case model.ValueType_BINARY: | |
| dest.PutStr(tag.Key, base64.StdEncoding.EncodeToString(tag.GetVBinary())) |
opentelemetry-collector-contrib/pkg/translator/jaeger/jaegerthrift_to_traces.go
Lines 152 to 153 in 5f1488f
| case jaeger.TagType_BINARY: | |
| dest.PutStr(tag.Key, base64.StdEncoding.EncodeToString(tag.GetVBinary())) |
Collector version
0.97
Environment information
No response
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
No response