Skip to content

Conversation

@fractalwrench
Copy link
Member

Goal

Converts OtelRumConfig to Kotlin. I've attempted to maintain API backwards compatibility with this change as much as possible & there shouldn't be a change in the API dump other than the addition of the final modifier.

@fractalwrench fractalwrench requested a review from a team as a code owner November 3, 2025 11:15
}

@Test
fun `setting a Supplier that returns null attributes is fine`() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted this test case (and the ability to pass null attributes) as keeping it would mean that getGlobalAttributesSupplier() would need to invoke the supplier, check whether the value was null, and then return the supplier again. I assumed removing the ability to pass null was preferable but don't have strong opinions if others disagree

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.00%. Comparing base (869e348) to head (206bfd2).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...a/io/opentelemetry/android/config/OtelRumConfig.kt 82.35% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
- Coverage   64.02%   64.00%   -0.02%     
==========================================
  Files         157      157              
  Lines        3099     3098       -1     
  Branches      318      318              
==========================================
- Hits         1984     1983       -1     
  Misses       1022     1022              
  Partials       93       93              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@LikeTheSalad LikeTheSalad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Cheers 👍

@LikeTheSalad LikeTheSalad merged commit 01ef395 into open-telemetry:main Nov 5, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants