Skip to content

Fix: Remote storage #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christyjacob4 merged 1 commit into from
Sep 25, 2023
Merged

Fix: Remote storage #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/http.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ function removeAllRuntimes(Table $activeRuntimes, Orchestration $orchestration):
* Copy code files from source to a temporary location on the executor
*/
if (!empty($source)) {
if (!$localDevice->transfer($source, $tmpSource, $sourceDevice)) {
if (!$sourceDevice->transfer($source, $tmpSource, $localDevice)) {
Copy link

@wess wess Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not tmpDevice?

throw new Exception('Failed to copy source code to temporary directory', 500);
};
}
Expand Down