fix: correct duplicate NULL check in oqsx_get_hybrid_params() (GHSA-mqwg-cg22-g8r8)#767
Merged
baentsch merged 3 commits intoApr 13, 2026
Conversation
iiviel
force-pushed
the
fix/oqs-kmgmt-copypaste-null-check
branch
from
4009d01 to
222e765
Compare
Member
|
Hi @iiviel ! I have seen that in this PR you have duplicated the code of #766 regarding signatures. Would you mind fixing that? Aside from that, the correction LGTM. Would you mind adding a new test / expanding an existing one to test the behavior under which you reproduced the error, so we can have that verified? |
iiviel
force-pushed
the
fix/oqs-kmgmt-copypaste-null-check
branch
6 times, most recently
from
4393c75 to
dfda7b9
Compare
…qwg-cg22-g8r8) Replace duplicate comp_privkey != NULL check with correct privkey != NULL check at oqs_kmgmt.c:412. The copy-paste error allowed the code to proceed with a dangling comp_privkey pointer when privkey had been freed, causing a use-after-free (CWE-416) readable via EVP_PKEY_get_params(). Signed-off-by: Eva Crystal <0xiviel@gmail.com>
iiviel
force-pushed
the
fix/oqs-kmgmt-copypaste-null-check
branch
from
dfda7b9 to
ab2df93
Compare
Contributor
Author
Member
Signed-off-by: Eva Crystal <0xiviel@gmail.com>
Contributor
Author
|
Hi @RodriM11! I've applied the LLVM formatting. Please let me know if anything else is needed! |
Member
…capabilities.c Signed-off-by: Eva Crystal <0xiviel@gmail.com>
Contributor
Author
|
Hi @RodriM11, reverted the unintended changes in oqsprov.c and oqsprov_capabilities.c. Should be good now! |
RodriM11
approved these changes
Apr 13, 2026
Member
|
Changes LGTM. Thanks for the contribution @iiviel ! |
baentsch
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the copy-paste NULL check bug at oqs_kmgmt.c:412. Replaces duplicate key->comp_privkey != NULL check with correct key->privkey != NULL check. Submitted per request in GHSA-mqwg-cg22-g8r8.