inmem: allow passing triggers (AST) data without conversion #7959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request has been automatically marked as stale because it has not had any activity in the last 30 days. |
Member
Author
|
|
sspaink
approved these changes
Nov 17, 2025
|
|
||
| for _, t := range db.triggers { | ||
| t.OnCommit(ctx, txn, event) | ||
| if wantsDataConversion && !t.SkipDataConversion { |
Member
There was a problem hiding this comment.
Suggested change
| if wantsDataConversion && !t.SkipDataConversion { | |
| if !t.SkipDataConversion { |
Using wantsDataConversion seems unnecessary here, because it will be true if !t.SkipDataConversion.
Member
Author
There was a problem hiding this comment.
True. I'll change that, thanks!
Member
Author
There was a problem hiding this comment.
No, that turned out to be not true after all, as wantsDataConversion depended on more conditions above.
v1/storage/inmem/inmem_bench_test.go
Outdated
|
|
||
| // Go 48750 ns/op 27040 B/op 311 allocs/op (no additional cost of triggers) | ||
| // AST 191501 ns/op 37585 B/op 616 allocs/op (extra cost du to converting back to Go values.. why?) | ||
| // AST 191501 ns/op 37585 B/op 616 allocs/op (extra cost du to converting back to Go values) |
Member
There was a problem hiding this comment.
Suggested change
| // AST 191501 ns/op 37585 B/op 616 allocs/op (extra cost du to converting back to Go values) | |
| // AST 191501 ns/op 37585 B/op 616 allocs/op (extra cost due to converting back to Go values) |
anderseknert
force-pushed
the
skip-data-conversion
branch
from
8fe54c8 to
3c16c07
Compare
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Fixes open-policy-agent#7958 Signed-off-by: Anders Eknert <[email protected]>
anderseknert
force-pushed
the
skip-data-conversion
branch
from
3c16c07 to
8c0f368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7958