runtime: Update server init check in runtime tests #7818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
charlieegan3
changed the title
charlieegan3
force-pushed
the
runtime-server-init-test
branch
3 times, most recently
from
ff5ad60 to
2c11563
Compare
sspaink
approved these changes
Aug 7, 2025
Member
sspaink
left a comment
sspaink
left a comment
There was a problem hiding this comment.
Looks better! Thanks for the fix.
I saw a panic here: https://github.com/open-policy-agent/opa/actions/runs/16652495113/job/47128828522 and think it's related to the server init check returning before the addrs are set. I update all cases where a similar check on logs is done. I am unsure how the log could come before the server is initialized, but sometimes funny things happen in race detector ordering and this looks more correct to me. Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
force-pushed
the
runtime-server-init-test
branch
from
2c11563 to
f0cefc5
Compare
Contributor
Author
|
Thanks for the review Sebastian! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a panic here: https://github.com/open-policy-agent/opa/actions/runs/16652495113/job/47128828522 and think it's related to the server init check returning before the addrs are set.
I update all cases where a similar check on logs is done.
I am unsure how the log could come before the server is initialized, but sometimes funny things happen in race detector ordering and this looks more correct to me.