cmd/parse: Move accidental pkg var to local var. #7813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
approved these changes
Jul 31, 2025
This commit moves an accidental package-level definition of the `opa parse` CLI subcommand to a local variable inside the `initParse` function, similar to how we do command initialization for all other OPA CLI subcommands. Before this change, it was possible to see panics from the package variable `cobra.Command` having some of its flags redefined. This fix makes it possible for `make generate-cli-docs` to run without error again. Signed-off-by: Philip Conrad <[email protected]>
philipaconrad
force-pushed
the
philip/fix-opa-parse
branch
from
3065850 to
c788762
Compare
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
ℹ️ Rebasing through the Github Web UI, then will merge... |
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
philipaconrad
added a commit
that referenced
this pull request
Jul 31, 2025
This commit moves an accidental package-level definition of the `opa parse` CLI subcommand to a local variable inside the `initParse` function, similar to how we do command initialization for all other OPA CLI subcommands. Before this change, it was possible to see panics from the package variable `cobra.Command` in `parse.go` having some of its flags redefined. This fix makes it possible for `make generate-cli-docs` to run without error again. Signed-off-by: Philip Conrad <[email protected]> (cherry picked from commit 47e2b74)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR moves an accidental package-level definition of the
opa parseCLI subcommand to a local variable inside theinitParsefunction, similar to how we do command initialization for all other OPA CLI subcommands.Before this change, it was possible to see panics from the package variable
cobra.Commandinparse.gohaving some of its flags redefined. This fix makes it possible formake generate-cli-docsto run without error again.How to test?
make -C docs generate-cli-docs, and see if the docs generate correctly.