cmd: allow branding #7797
Merged
cmd: allow branding #7797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
srenatus
force-pushed
the
sr/qwxrznxzoupw
branch
from
1d362e2 to
4098301
Compare
johanfylling
approved these changes
Jul 24, 2025
| } | ||
|
|
||
| func init() { | ||
| func initFmt(root *cobra.Command, _ string) { |
Contributor
There was a problem hiding this comment.
There are a couple of examples in the long description here that say opa fmt .... Should they use root.Name()?
This change allows users that build their own executable or "spin" of OPA to give it a name, and have it reference itself properly in help texts. It's a vanity thing, but I think some people would appreciate it, hat tip to the international association of pedants. Signed-off-by: Stephan Renatus <[email protected]> Co-authored-by: kevinstyra <[email protected]>
srenatus
force-pushed
the
sr/qwxrznxzoupw
branch
from
4098301 to
481c3e8
Compare
philipaconrad
added a commit
to philipaconrad/opa
that referenced
this pull request
Jul 31, 2025
This commit fixes an issue when upgrading codebases to OPA v1.7.0. In PR open-policy-agent#7797, we introduced the ability to provide "branding" information in OPA commands and help messages, which would allow easier customized OPA distributions in the future. However, this changeset removed the public symbol `cmd.RootCommand`, and required refactoring to use `cmd.Command`, which breaks automated upgrades, such as those done by Dependabot. This PR adds back the missing symbol, with the original/default "OPA" branding provided. This should allow existing codebases to upgrade without requiring any code changes. Signed-off-by: Philip Conrad <[email protected]>
philipaconrad
added a commit
to philipaconrad/opa
that referenced
this pull request
Jul 31, 2025
This commit fixes an issue when upgrading codebases to OPA v1.7.0. In PR open-policy-agent#7797, we introduced the ability to provide "branding" information in OPA commands and help messages, which would allow easier customized OPA distributions in the future. However, this changeset removed the public symbol `cmd.RootCommand`, and required refactoring to use `cmd.Command`, which breaks automated upgrades, such as those done by Dependabot. This PR adds back the missing symbol, with the original/default "OPA" branding provided. This should allow existing codebases to upgrade without requiring any code changes. Signed-off-by: Philip Conrad <[email protected]>
philipaconrad
added a commit
that referenced
this pull request
Jul 31, 2025
This commit fixes an issue when upgrading codebases to OPA v1.7.0. In PR #7797, we introduced the ability to provide "branding" information in OPA commands and help messages, which would allow easier customized OPA distributions in the future. However, this changeset removed the public symbol `cmd.RootCommand`, and required refactoring to use `cmd.Command`, which breaks automated upgrades, such as those done by Dependabot. This PR adds back the missing symbol, with the original/default "OPA" branding provided. This should allow existing codebases to upgrade without requiring any code changes. Signed-off-by: Philip Conrad <[email protected]>
philipaconrad
added a commit
that referenced
this pull request
Jul 31, 2025
This commit fixes an issue when upgrading codebases to OPA v1.7.0. In PR #7797, we introduced the ability to provide "branding" information in OPA commands and help messages, which would allow easier customized OPA distributions in the future. However, this changeset removed the public symbol `cmd.RootCommand`, and required refactoring to use `cmd.Command`, which breaks automated upgrades, such as those done by Dependabot. This PR adds back the missing symbol, with the original/default "OPA" branding provided. This should allow existing codebases to upgrade without requiring any code changes. Signed-off-by: Philip Conrad <[email protected]>
This was referenced Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users that build their own executable or "spin" of OPA to give it a name, and have it reference itself properly in help texts.
It's a vanity thing, but I think some people would appreciate it, hat tip to the international association of pedants.