-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Upgrade interned jwx (0.9.x) with github.com/lestrrat-go/jwx/v3 #7733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 25 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
8eccf4b
First pass replacing internal/jwx with jwx v3
lestrrat 0cd5fa7
Result after running go mod vendor
lestrrat 1440bc9
Just use jwa.LookupSignatureAlgorithm
lestrrat efdceb6
Fix verify/verify_test
lestrrat f6931e1
Use the jws/jwsbb functions
lestrrat d1a6574
Update signing
lestrrat d1e90ac
remove panic introduced for debugging
lestrrat 14a6469
Add t.Helper to better report where the failure is
lestrrat 917c244
Add t.Helper to better report where the failure is
lestrrat 12a6727
Fix v1/topdown with latest jwsbb
lestrrat 3394b22
Let jwsbb do all the verification
lestrrat 4e32199
Check error return
lestrrat a5768f0
use any
lestrrat 21fd957
me being silly
lestrrat 2d71b51
Update error message
lestrrat 1ffce27
Check for errors
lestrrat da78fcc
wrap error
lestrrat 40ba370
Change expected error message
lestrrat 8b09089
Fix error messages
lestrrat 23dd6bf
Assert len(signature) == 1
lestrrat c129930
Run go mod vendor
lestrrat cffd719
This should be PRIVATE KEY
lestrrat e10076f
tweak
lestrrat 3275d4d
align mapstructure version
lestrrat 37c4381
check for algorithm before reading file
lestrrat de56ec6
Update jwx to v3.0.9
lestrrat 77aee7f
Vendoring
johanfylling 30ddb69
Fixing tests
johanfylling 042d5e1
Merge branch 'main' into jwx3
johanfylling 8429646
Fixing linter issues
johanfylling 666105c
Update jwx to v3.0.10
lestrrat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think vendoring won't impede reviewing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was also actively updating the code, so... :) I will add the vendored code in my subsequent commits