Skip to content

Conversation

@nejec
Copy link
Contributor

@nejec nejec commented May 20, 2025

Why the changes in this PR are needed?

With the refactoring of the webpage static files location, helm-kubernetes-quickstart bundle file became corrupt and previous, non-working bundle was deployed.

Current version of the file fails to evaluate

$ opa eval -b helm-kubernetes-quickstart 'data'
{
  "errors": [
    {
      "message": "loading error: bundle helm-kubernetes-quickstart: bundle load failed on manifest decode: invalid character '\\x00' looking for beginning of value"
    }
  ]
}

What are the changes in this PR?

Previous (from release 1.4.2) , working version of helm-kubernetes-quickstart bundle is included in this pull request and can be used as input for opa/kube-mgmt helm chart end to end test

$ opa eval -b helm-kubernetes-quickstart 'data'
{
  "result": [
    {
      "expressions": [
        {
          "value": {
            "helm_kubernetes_quickstart": {
              "deny": [],
              "main": {
                "apiVersion": "admission.k8s.io/v1beta1",
                "kind": "AdmissionReview",
                "response": {
                  "allowed": true
                }
              },
              "response": {
                "allowed": true
              },
              "whitelist": [
                "*.dev.acmecorp.com",
                "*.test.acmecorp.com"
              ]
            },
            "test_helm_kubernetes_quickstart": {
              "test_allow_inside_example_namespace": true,
              "test_allow_outside_example_namespace": true,
              "test_deny_inside_example_namespace": true
            }
          },
          "text": "data",
          "location": {
            "row": 1,
            "col": 1
          }
        }
      ]
    }
  ]
}

Notes

  • At the moment, opa/kube-mgmt end to end tests are broken and will be fixed once this change is deployed. Additionally, opa/kube-mgmt end to end tests will be updated with new uri to the bundle file (previously: /helm-kubernetes-quickstart, now: /external-resources/bundles/helm-kubernetes-quickstart).
  • Similar error was already addressed once in this commit.

@netlify
Copy link

netlify bot commented May 20, 2025

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit fbc726a
🔍 Latest deploy log https://app.netlify.com/projects/openpolicyagent/deploys/682ce65309f9340008897300
😎 Deploy Preview https://deploy-preview-7606--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@charlieegan3
Copy link
Contributor

hey @nejec, thanks for fixing this one! I must have made a mistake in porting over this file from the old site. If you can sign off your commit we can get this in ASAP.

Sorry for the inconvenience here.

@nejec nejec force-pushed the fix/helm-quickstart-bundle branch 2 times, most recently from f01a4ca to 605411f Compare May 21, 2025 07:09
With the refactoring of the webpage static files location, new
`helm-kubernetes-quickstart` bundle became corrupt and previous,
non-working bundle was deployed.

This change replaces currently deployed bundle, which is causing the
following error with `opa eval -b helm-kubernetes-quickstart 'data'`

```
loading error: bundle helm-kubernetes-quickstart: bundle load failed
on manifest decode: invalid character '\\x00' looking for beginning
of value
```

This change also fixes the failing e2e pipeline in `opa/kube-mgmt` helm
chart, which depends on the location (and source) of this bundle.

Signed-off-by: Jernej Porenta <[email protected]>
@nejec nejec force-pushed the fix/helm-quickstart-bundle branch from 605411f to fb3625f Compare May 21, 2025 07:24
@nejec nejec requested a review from charlieegan3 May 21, 2025 07:42
@charlieegan3 charlieegan3 merged commit 22d26df into open-policy-agent:main May 21, 2025
28 checks passed
aromeyer pushed a commit to aromeyer/opa that referenced this pull request May 21, 2025
With the refactoring of the webpage static files location, new
`helm-kubernetes-quickstart` bundle became corrupt and previous,
non-working bundle was deployed.

This change replaces currently deployed bundle, which is causing the
following error with `opa eval -b helm-kubernetes-quickstart 'data'`

```
loading error: bundle helm-kubernetes-quickstart: bundle load failed
on manifest decode: invalid character '\\x00' looking for beginning
of value
```

This change also fixes the failing e2e pipeline in `opa/kube-mgmt` helm
chart, which depends on the location (and source) of this bundle.

Signed-off-by: Jernej Porenta <[email protected]>
Signed-off-by: aromeyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants