Apply modernize linter fixes #7599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sspaink
approved these changes
May 20, 2025
Member
sspaink
left a comment
sspaink
left a comment
There was a problem hiding this comment.
Great job! Looks like all good improvements.
Following up on open-policy-agent#7566, and now applying the more exciting modernizations. fmt.Appendf was new to me! But especially the contains checks are so much better IMHO. I have reviewed all changes myself and did a few manual changes where it became obvious that things could be improved a little further. (the modernize analyzer still has some issues running against OPA, and I have manually worked around those for the time being) Signed-off-by: Anders Eknert <[email protected]>
aromeyer
pushed a commit
to aromeyer/opa
that referenced
this pull request
May 21, 2025
Following up on open-policy-agent#7566, and now applying the more exciting modernizations. fmt.Appendf was new to me! But especially the contains checks are so much better IMHO. I have reviewed all changes myself and did a few manual changes where it became obvious that things could be improved a little further. (the modernize analyzer still has some issues running against OPA, and I have manually worked around those for the time being) Signed-off-by: Anders Eknert <[email protected]> Signed-off-by: aromeyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #7566, and now applying the more exciting modernizations. fmt.Appendf was new to me! But especially the contains checks are so much better IMHO. I have reviewed all changes myself and did a few manual changes where it became obvious that things could be improved a little further.
(the modernize analyzer still has some issues running against OPA, and I have manually worked around those for the time being)