perf: ref.String() shortcut on single var term ref #7595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
force-pushed
the
perf-single-term-ref-str
branch
from
419879a to
9b5a83d
Compare
This is a marginal improvement, but considering this is one of the most called functions in OPA, the overall impact is still substantial. Concretely, this simple change reduces the number of allocations done in the `regal lint bundle` benchmark by about 655K(!) **main vs. change** ``` BenchmarkRefString/SingleTerm-12 56586423 20.70 ns/op 16 B/op 1 allocs/op BenchmarkRefString/SingleTerm-12 581425396 2.07 ns/op 0 B/op 0 allocs/op ``` Signed-off-by: Anders Eknert <[email protected]>
anderseknert
force-pushed
the
perf-single-term-ref-str
branch
from
9b5a83d to
59d4e71
Compare
aromeyer
pushed a commit
to aromeyer/opa
that referenced
this pull request
May 21, 2025
…#7595) This is a marginal improvement, but considering this is one of the most called functions in OPA, the overall impact is still substantial. Concretely, this simple change reduces the number of allocations done in the `regal lint bundle` benchmark by about 655K(!) **main vs. change** ``` BenchmarkRefString/SingleTerm-12 56586423 20.70 ns/op 16 B/op 1 allocs/op BenchmarkRefString/SingleTerm-12 581425396 2.07 ns/op 0 B/op 0 allocs/op ``` Signed-off-by: Anders Eknert <[email protected]> Signed-off-by: aromeyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a marginal improvement, but considering this is one of the most called functions in OPA, the overall impact is still substantial. Concretely, this simple change reduces the number of allocations done in the
regal lint bundlebenchmark by about 655K(!)main vs. change