Skip to content

Conversation

@sedovmik
Copy link
Contributor

@sedovmik sedovmik commented Mar 2, 2025

Why the changes in this PR are needed?

This PR adds support for the query_parameters_to_set field in responses. This sets or overrides query parameters in the original request before it's forwarded to upstream services.

What are the changes in this PR?

Update documentation to include the new field

Notes to assist PR review:

@netlify
Copy link

netlify bot commented Mar 2, 2025

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 5d7fb26
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/67cb479b709b190008cf2be0
😎 Deploy Preview https://deploy-preview-7405--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@johanfylling johanfylling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

We'll merge this once the original opa-envoy-plugin PR is merged.

* `body` (optional): the response body
* `dynamic_metadata` (optional): an object representing dynamic metadata to be consumed by the next Envoy filter.
* `query_parameters_to_remove` (optional): is an array containing the names of string query parameters to be removed.
* `query_parameters_to_set` (optional): an object mapping parameter names to values (string) or arrays of values (for multiple values with the same key)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we can add a longer description in https://www.openpolicyagent.org/docs/latest/envoy-primer/#example-policy-with-additional-controls and then a brief one here. Same for query_parameters_to_remove if you can do that as well. Thanks

@ashutosh-narkar ashutosh-narkar merged commit fcf2182 into open-policy-agent:main Mar 7, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants