-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs: Add note about v1.0 addr behaviour #7398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| it's good practice to bind OPA to localhost by default if OPA is not intended to | ||
| be exposed to remote services. | ||
|
|
||
| If you need to replicate the v0.x behaviour, you can use the `--addr` flag to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps worth explicitly calling out that this is likely necessary when running OPA in Docker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've added an info block for that now
srenatus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick aside, lgtm
docs/content/deployments.md
Outdated
| in other environments. | ||
|
|
||
| More information can be found in the | ||
| [security documentation](https://www.openpolicyagent.org/docs/latest/security/#interface-binding). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] Should this be a relevant....no, a relative link? Or can't we do that with # anchors? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's fair, I have updated.
6ac6fde to
9edce11
Compare
9edce11 to
567f579
Compare
https://github.com/orgs/open-policy-agent/discussions/671 open-policy-agent/opa#7398 Signed-off-by: Charlie Egan <[email protected]> Co-authored-by: Charlie Egan <[email protected]>
|
@charlieegan3 I am having issue when migrating to v1 #7735 |
|
@liqiongbu yeah, a pretty common issue people run into when bumping OPA to 1.0+ is that from 1.0 and onwards, OPA's server now only binds to the localhost interface by default, where it precvously would bind to all interfaces. Docker doesn't seem too happy about exposing localhost to the outside, which typically manifests in the way you describe. What I don't understand why there is a difference if you start both versions with localhost explicitly set as the netwokr interface. That should break the same way in any version. We only changed the default when nothing is provided. |
|
This is also where I get confusions from, since we always explicitly set addr, I should expect I don't have to overwrite this in v1 migration |
|
I think I linked the wrong issue, here is the one: #7735 |
|
Hey @liqiongbu - let's continue the chat on the new issue! 🙂 |
Fixes #7360
Also https://github.com/orgs/open-policy-agent/discussions/662#discussioncomment-12338962