Autowire OPAProperties in OPAAutoConfiguration
#30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To properly use configuration properties loaded using `OPAProperties`, this bean should be autowired in `OPAAutoConfiguration`. Autowiring has been made optional to maintain backward compatibility.
Contributor
Author
|
@chendrix Please also consider this change in the new release, if possible. |
ali-jalaal
deleted the
Autowire-OPAProperties-in-OPAAutoConfiguration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPAProperties, this bean should be autowired inOPAAutoConfigurationbean.opaPropertiesobject immutable,opaPathfield has been restored.opaPathcan be set by constructors.opaPathis not set and current object (opaAuthorizationManager) is instantiated as a Spring bean, it will be set based onopaProperties.getPath().Related to #22