Skip to content

perf: use ast.Value and []string in request input #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

perf: use ast.Value and []string in request input #676

merged 1 commit into from
Apr 5, 2025

Conversation

@regeda
Copy link
Contributor

@regeda regeda commented Mar 6, 2025

Before:

BenchmarkCheck-12          28180             42507 ns/op           28437 B/op        570 allocs/op

After:

BenchmarkCheck-12          29908             40675 ns/op           27856 B/op        552 allocs/op

@regeda regeda force-pushed the perf-improve branch 2 times, most recently from c629bb2 to 9dc2b65 Compare March 8, 2025 09:54
tjons
tjons approved these changes Apr 5, 2025
View reviewed changes
Copy link
Collaborator

@tjons tjons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice optimization!

@tjons tjons merged commit f33eb45 into open-policy-agent:main Apr 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjons tjons tjons approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@regeda @tjons