Skip to content

Conversation

@Ben-Louis
Copy link
Collaborator

@Ben-Louis Ben-Louis commented Apr 17, 2023

Motivation

Modification

  1. Update docker image to ubuntu-22.04 due to The Ubuntu 18.04 Actions runner image will begin deprecation on 2022/08/08 and will be fully unsupported by 2023/04/03 actions/runner-images#6002
  2. Add unit test with pytorch 2.0
  3. Fix model config links in document

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@Ben-Louis Ben-Louis requested a review from Tau-J April 17, 2023 02:21
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (896e9d5) 82.25% compared to head (b63e942) 82.23%.

❗ Current head b63e942 differs from pull request most recent head 8707521. Consider uploading reports for the commit 8707521 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2239      +/-   ##
===========================================
- Coverage    82.25%   82.23%   -0.02%     
===========================================
  Files          228      229       +1     
  Lines        13387    13519     +132     
  Branches      2268     2295      +27     
===========================================
+ Hits         11011    11117     +106     
- Misses        1862     1874      +12     
- Partials       514      528      +14     
Flag Coverage Δ
unittests 82.23% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ben-Louis Ben-Louis changed the title [Doc] Fix config paths [Fix] Update Ubuntu version to fix CI Apr 17, 2023
@Tau-J Tau-J merged commit 7dbb1b7 into open-mmlab:dev-1.x Apr 17, 2023
@Ben-Louis Ben-Louis deleted the fix-config-path branch April 26, 2023 18:00
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants