Skip to content

Conversation

@Ben-Louis
Copy link
Collaborator

Motivation

Modification

replace the has_final_layer argument with the final_layer argument, which is a dictionary containing the parameters for the final conv2d layer.

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 69.23% and project coverage change: -0.04 ⚠️

Comparison is base (b1876b8) 82.34% compared to head (5003fee) 82.30%.

❗ Current head 5003fee differs from pull request most recent head fdd23aa. Consider uploading reports for the commit fdd23aa to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2126      +/-   ##
===========================================
- Coverage    82.34%   82.30%   -0.04%     
===========================================
  Files          227      227              
  Lines        13340    13335       -5     
  Branches      2261     2257       -4     
===========================================
- Hits         10985    10976       -9     
- Misses        1844     1850       +6     
+ Partials       511      509       -2     
Flag Coverage Δ
unittests 82.30% <69.23%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/models/heads/heatmap_heads/ae_head.py 82.65% <ø> (ø)
mmpose/models/heads/regression_heads/dsnt_head.py 86.48% <ø> (ø)
...heads/regression_heads/integral_regression_head.py 76.19% <33.33%> (-0.61%) ⬇️
mmpose/models/heads/coord_cls_heads/simcc_head.py 90.38% <50.00%> (+0.09%) ⬆️
mmpose/models/heads/heatmap_heads/cpm_head.py 93.63% <100.00%> (+0.05%) ⬆️
mmpose/models/heads/heatmap_heads/heatmap_head.py 87.50% <100.00%> (+5.01%) ⬆️
mmpose/models/heads/heatmap_heads/vipnas_head.py 88.13% <100.00%> (+0.20%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tau-J
Copy link
Collaborator

Tau-J commented Mar 29, 2023

Have you verified the test accuracy?

@Ben-Louis
Copy link
Collaborator Author

Yeah, I have verified the test accuracy of ViTPose-small and CPM on COCO

@Tau-J Tau-J merged commit 081e3f9 into open-mmlab:dev-1.x Mar 29, 2023
@Ben-Louis Ben-Louis deleted the refactor-neck-head branch March 29, 2023 17:33
@Ben-Louis Ben-Louis mentioned this pull request Apr 4, 2023
6 tasks
Tau-J pushed a commit that referenced this pull request Apr 6, 2023
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants