fix a small bug#908
Merged
sshaoshuai merged 1 commit intoopen-mmlab:masterfrom Mar 29, 2022
Yzichen:yzc
Merged
Conversation
Collaborator
|
Thanks for the PR! Yes, you are right. The first part is a small error. In the second part of your PR, I require cur_gt.shape[0] > 0 to avoid some unnecessary errors since some codes in the repo may require each scene has at least one GT, or it will cause some errors. Nevertheless, thanks for your PR and I will accept it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If k>0 is used as the condition, cur_gt.shape[0] will always be greater than 0. For some scenes without targets, cur_gt will be a zero tensor with shape (1, 8), which affects recall_dict['gt'], As a result, it affects the calculation of recall.