Skip to content

[yagp_hooks_collector] Fix null edata access#22

Merged
leborchuk merged 1 commit intomainfrom
fix-null-edata-access
Feb 10, 2026
Merged

[yagp_hooks_collector] Fix null edata access#22
leborchuk merged 1 commit intomainfrom
fix-null-edata-access

Conversation

@NJrslv
Copy link

@NJrslv NJrslv commented Feb 9, 2026

We faced an issue - segments fail with backtrace

#7  0x00007f9b2adbf2e0 in set_qi_error_message (req=0x55f24a6011f0) at src/ProtoUtils.cpp:124
#8  0x00007f9b2adc30d9 in EventSender::collect_query_done (this=0x55f24a5489f0, query_desc=0x55f24a71ca68, status=METRICS_QUERY_ERROR) at src/EventSender.cpp:222
#9  0x00007f9b2adc23e1 in EventSender::query_metrics_collect (this=0x55f24a5489f0, status=METRICS_QUERY_ERROR, arg=0x55f24a71ca68) at src/EventSender.cpp:53

the root cause here is we're trying to send info about error message in a hooks collector. For some queries ErrorData struckture could be NULL despite the fact that an error has occurred. it depends on error type and location of the error. So we should check if we had info about error details before using it.

@leborchuk leborchuk merged commit c4613c1 into main Feb 10, 2026
50 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants