chore: clarify event/domain scoping, lifecycle #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
toddbaert
requested review from
DBlanchard88,
Kavindu-Dodan,
beeme1mr,
fabriziodemaria,
federicobond,
gruebel,
justinabrahms,
kinyoklion,
lukas-reining,
moredip,
nicklasl and
thomaspoignant
Signed-off-by: Todd Baert <[email protected]>
2 tasks
beeme1mr
approved these changes
Feb 28, 2024
toddbaert
commented
Feb 28, 2024
Signed-off-by: Todd Baert <[email protected]>
weyert
approved these changes
Feb 28, 2024
toddbaert
commented
Feb 28, 2024
Signed-off-by: Todd Baert <[email protected]>
lukas-reining
approved these changes
Feb 28, 2024
DBlanchard88
approved these changes
Feb 28, 2024
|
Looks good to me! Sorry about the delay, I'm moving out to another country this week 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some additional non-normative text to clarify a few things at the prompt of @federicobond .
The meaning and justification should be self-evident, and if it's not I did a bad job. 😅