Skip to content

Conversation

@Kavindu-Dodan
Copy link
Contributor

This PR

Adds an appendix section [1]

Appendix is expected to contain extra information for both OpenFeature maintainers and users

[1] - open-feature/ofep#71 (comment)

@Kavindu-Dodan Kavindu-Dodan requested a review from toddbaert as a code owner July 13, 2023 17:19
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@toddbaert toddbaert self-requested a review July 17, 2023 16:59
Kavindu-Dodan and others added 2 commits July 17, 2023 12:30
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
@toddbaert
Copy link
Member

Relative to most spec changes, this one seems low risk and high reward. I personally would love to remove the dependency cycle in our SDK repos that results from including the flagd provider. The OFEP was also well-received, so I'm going to merge this EOD unless I hear objections.

@federicobond
Copy link
Member

Just to check, this would effectively deprecate the caching tests scenarios declared in the e2e test-harness when using the in-memory provider, right?

toddbaert and others added 2 commits August 1, 2023 14:36
Co-authored-by: Federico Bond <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Federico Bond <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
@toddbaert
Copy link
Member

toddbaert commented Aug 1, 2023

Just to check, this would effectively deprecate the caching tests scenarios declared in the e2e test-harness when using the in-memory provider, right?

Yes, good call. I think the caching tests are no longer relevant, and beyond the scope of what SDKs should be testing.

In fact, we may want to move the gherkin suite(s) into their own appendix in the spec and de-emphasize the test-harness repo, which is tightly associated with flagd.

@toddbaert toddbaert requested a review from justinabrahms August 1, 2023 20:26
@toddbaert toddbaert merged commit 2a2539d into open-feature:main Aug 1, 2023
@Kavindu-Dodan Kavindu-Dodan deleted the feat/appendix-section branch February 15, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants