Spec change for named client -> provider mappings #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
reviewed
Apr 28, 2023
toddbaert
reviewed
Apr 28, 2023
Member
|
I think we might need additional point(s) about retrieving a named client bound to a non-default provider. I'm also wondering if we need to spec that clients retrieved with a given name return the same object instance (or do they just generate a new client associated with the provider bound to that name?) |
toddbaert
requested review from
InTheCloudDan,
Kavindu-Dodan,
agentgonzo,
bacherfl,
beeme1mr,
benjiro,
cdonnellytx,
dabeeeenster,
davejohnston,
hlipsig,
james-milligan,
josecolella,
kinyoklion,
lopitz,
lukas-reining,
matthewelwell,
moredip,
rgrassian-split,
skyerus,
tcarrio,
thisthat,
thiyagu06,
thomaspoignant and
weyert
Signed-off-by: Justin Abrahms <[email protected]>
Signed-off-by: Justin Abrahms <[email protected]>
justinabrahms
force-pushed
the
client-provider-mapping
branch
from
a44e6f2 to
1b08e0d
Compare
lukas-reining
approved these changes
May 2, 2023
Member
lukas-reining
left a comment
lukas-reining
left a comment
There was a problem hiding this comment.
Spec seems fine like this and the use case is totally there.
thomaspoignant
approved these changes
May 2, 2023
Member
thomaspoignant
left a comment
thomaspoignant
left a comment
There was a problem hiding this comment.
This addition will make the switch between providers even simpler 👏
beeme1mr
approved these changes
May 2, 2023
kinyoklion
approved these changes
May 2, 2023
This was referenced May 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds support for mapping a named client to a specific provider.
Related Issues
Refs open-feature/ofep#56
Notes
Example of this implemented in Java: open-feature/java-sdk#388