Skip to content

Conversation

@skyerus
Copy link
Contributor

@skyerus skyerus commented Dec 6, 2022

This PR

Revives the STATIC reason in order to determine which values are cacheable.
Introduces the CACHED reason in order to report to the client that the value has been retrieved from cache.

Related Issues

Fixes #165

Notes

Follow-up Tasks

How to test

@skyerus skyerus requested a review from toddbaert as a code owner December 6, 2022 11:54
@beeme1mr beeme1mr requested review from a team and justinabrahms December 6, 2022 14:19
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though reasons are free form, I think these additions represent important information. We've seen the need for them come up in a few different implementations.

Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Skye Gill <[email protected]>
@beeme1mr beeme1mr merged commit 928d513 into open-feature:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Amend provider's reasons to include static & cached

4 participants