Skip to content

Conversation

@ajhelsby
Copy link
Contributor

@ajhelsby ajhelsby commented Nov 2, 2022

This PR

Adds all the features required to reach compliance with spec 0.2.0

Related Issues

Fixes #13

Notes

The fixes around open-feature/spec#142 will be a breaking change to the sdk

Follow-up Tasks

How to test

Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
…the client

Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
# Conflicts:
#	open_feature/open_feature_client.py
Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
…equired when an error has been found

Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
@ajhelsby ajhelsby changed the title Feature/spec 0.5.0 feat: spec-0.5.0 Nov 2, 2022
@matthewelwell
Copy link
Member

matthewelwell commented Nov 2, 2022

The commits specific to 0.5.0 seem fine, but I've left a few comments on the PR for the 0.2.0 updates which can be seen in this PR.

Can we cherry pick the 0.5.0 commit onto a clean branch or does it rely on previous commits?

@ajhelsby

Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
@toddbaert
Copy link
Member

@ajhelsby Regarding this and #40, feel free to combine them into one if that's easier for you.

@ajhelsby ajhelsby closed this Nov 11, 2022
@ajhelsby ajhelsby deleted the feature/spec-0.5.0 branch November 11, 2022 10:25
kikihakiem pushed a commit to ResalApps/openfeature-python-sdk that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update SDK to be compliant with spec v0.5.0

4 participants