ci: add mypy type checking and fix/exclude minor issues#255
Merged
federicobond merged 2 commits intoopen-feature:mainfrom Jan 7, 2024
Merged
ci: add mypy type checking and fix/exclude minor issues#255federicobond merged 2 commits intoopen-feature:mainfrom
federicobond merged 2 commits intoopen-feature:mainfrom
Conversation
Signed-off-by: gruebel <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
==========================================
+ Coverage 93.82% 93.83% +0.01%
==========================================
Files 16 16
Lines 437 438 +1
==========================================
+ Hits 410 411 +1
Misses 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
federicobond
reviewed
Jan 6, 2024
Member
federicobond
left a comment
There was a problem hiding this comment.
There is no openfeature/__init__.py file to turn openfeature into an implicit namespace package. See #199
Other than that, LGTM.
Member
Author
|
ok, no problem. Need to adjust the |
Signed-off-by: gruebel <[email protected]>
federicobond
approved these changes
Jan 7, 2024
kikihakiem
pushed a commit
to ResalApps/openfeature-python-sdk
that referenced
this pull request
Aug 28, 2025
…ure#255) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
pre-commit, which will be triggered during CIStrEnumimport to use the Python system info, so the type checker can properly handle itMappingProxyTypeare needed, because the original type hints are differentFollow-up Tasks
mypychecks with follow-up PRs tillstrictmode can be enabled