fix: API server warning for empty imagePullSecrets#774
Merged
beeme1mr merged 1 commit intoopen-feature:mainfrom Jul 14, 2025
Merged
fix: API server warning for empty imagePullSecrets#774beeme1mr merged 1 commit intoopen-feature:mainfrom
beeme1mr merged 1 commit intoopen-feature:mainfrom
Conversation
Signed-off-by: Yosiah de Koeyer <[email protected]>
lukas-reining
approved these changes
Jul 13, 2025
Member
lukas-reining
left a comment
There was a problem hiding this comment.
Thank you @Y0sh1dk!
This looks good to me :)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #774 +/- ##
===========================================
- Coverage 86.51% 71.36% -15.15%
===========================================
Files 19 30 +11
Lines 1587 2305 +718
===========================================
+ Hits 1373 1645 +272
- Misses 173 612 +439
- Partials 41 48 +7
... and 10 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
beeme1mr
approved these changes
Jul 14, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Fixes API server warning for empty imagePullSecrets
Previously
FlagdConfiguration.ImagePullSecretswould be[""]when no--image-pull-secretsis supplied, this results in a invalidDeploymentresource when aFlagdresource is applied. After this changeFlagdConfiguration.ImagePullSecretsresults in[]which ensures the generatedDeployments don't throw API server warnings.