chore(main): release server-sdk 1.22.0#1399
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates @openfeature/server-sdk to version 1.22.0 and introduces a new feature to expose JS SDK identity on client metadata. The review feedback points out a discrepancy between the devDependencies and peerDependencies versions for @openfeature/core, suggesting that peerDependencies should be updated to maintain compatibility for the new feature. Additionally, it is suggested to remove development dependency updates from the changelog as they typically do not affect end-users.
|
|
||
| * The following workspace dependencies were updated | ||
| * devDependencies | ||
| * @openfeature/core bumped from ^1.9.2 to ^1.11.0 |
There was a problem hiding this comment.
Including devDependencies updates in the changelog is unusual as these changes typically do not affect the end-users of the package. If this bump to @openfeature/core v1.11.0 is required for the new "js sdk identity" feature to function correctly (e.g., due to type changes or new metadata fields), then the peerDependencies in package.json should likely be updated as well. If it is purely a development-time dependency update, it should probably be removed from the changelog to avoid confusion.
| }, | ||
| "devDependencies": { | ||
| "@openfeature/core": "^1.9.2" | ||
| "@openfeature/core": "^1.11.0" |
There was a problem hiding this comment.
The devDependencies for @openfeature/core has been bumped to ^1.11.0, but the peerDependencies (on line 51) remains at ^1.10.0. If the new feature "expose js sdk identity on client metadata" relies on functionality or types introduced in @openfeature/core v1.11.0, the peerDependencies should also be updated to ^1.11.0. This ensures that consumers of the SDK are using a compatible version of the core package and prevents potential runtime or type errors.
326510e to
000648a
Compare
000648a to
cdb8379
Compare
cdb8379 to
66f4028
Compare
d27ac2f to
0fb5c52
Compare
Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
0fb5c52 to
ce04cfb
Compare
🤖 I have created a release beep boop
1.22.0 (2026-06-12)
✨ New Features
This PR was generated with Release Please. See documentation.