Skip to content

chore(main): release server-sdk 1.22.0#1399

Closed
openfeaturebot wants to merge 1 commit into
mainfrom
release-please--branches--main--components--server-sdk
Closed

chore(main): release server-sdk 1.22.0#1399
openfeaturebot wants to merge 1 commit into
mainfrom
release-please--branches--main--components--server-sdk

Conversation

@openfeaturebot

@openfeaturebot openfeaturebot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

🤖 I have created a release beep boop

1.22.0 (2026-06-12)

✨ New Features

  • expose js sdk identity on client metadata (#1376) (6c437e7)

This PR was generated with Release Please. See documentation.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates @openfeature/server-sdk to version 1.22.0 and introduces a new feature to expose JS SDK identity on client metadata. The review feedback points out a discrepancy between the devDependencies and peerDependencies versions for @openfeature/core, suggesting that peerDependencies should be updated to maintain compatibility for the new feature. Additionally, it is suggested to remove development dependency updates from the changelog as they typically do not affect end-users.

Comment thread packages/server/CHANGELOG.md Outdated

* The following workspace dependencies were updated
* devDependencies
* @openfeature/core bumped from ^1.9.2 to ^1.11.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Including devDependencies updates in the changelog is unusual as these changes typically do not affect the end-users of the package. If this bump to @openfeature/core v1.11.0 is required for the new "js sdk identity" feature to function correctly (e.g., due to type changes or new metadata fields), then the peerDependencies in package.json should likely be updated as well. If it is purely a development-time dependency update, it should probably be removed from the changelog to avoid confusion.

Comment thread packages/server/package.json Outdated
},
"devDependencies": {
"@openfeature/core": "^1.9.2"
"@openfeature/core": "^1.11.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The devDependencies for @openfeature/core has been bumped to ^1.11.0, but the peerDependencies (on line 51) remains at ^1.10.0. If the new feature "expose js sdk identity on client metadata" relies on functionality or types introduced in @openfeature/core v1.11.0, the peerDependencies should also be updated to ^1.11.0. This ensures that consumers of the SDK are using a compatible version of the core package and prevents potential runtime or type errors.

@openfeaturebot openfeaturebot force-pushed the release-please--branches--main--components--server-sdk branch from 326510e to 000648a Compare April 28, 2026 20:29
@openfeaturebot openfeaturebot force-pushed the release-please--branches--main--components--server-sdk branch from 000648a to cdb8379 Compare May 19, 2026 16:59
@openfeaturebot openfeaturebot force-pushed the release-please--branches--main--components--server-sdk branch from cdb8379 to 66f4028 Compare June 1, 2026 18:19
@openfeaturebot openfeaturebot force-pushed the release-please--branches--main--components--server-sdk branch 2 times, most recently from d27ac2f to 0fb5c52 Compare June 12, 2026 16:29
Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
@openfeaturebot openfeaturebot force-pushed the release-please--branches--main--components--server-sdk branch from 0fb5c52 to ce04cfb Compare June 12, 2026 16:46
@toddbaert toddbaert closed this Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants